Remove SliceHeader and replace. #12368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ayushr2
reviewed
Dec 12, 2025
Collaborator
|
Also please squash all your commits: Lines 95 to 99 in 63343ff |
nicolasgarza
force-pushed
the
remove-slice-header
branch
from
ae6cff4 to
c73437c
Compare
ayushr2
approved these changes
Dec 13, 2025
Collaborator
|
Thanks for your contribution! |
also, add memutil, sharedmem_unsafe to nogo to fix build errors (false positive on analyze)
nicolasgarza
force-pushed
the
remove-slice-header
branch
from
c73437c to
52fddb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes most uses of SliceHeader as referenced by #8422
SliceHeader is deprecated - so we prefer to use unsafe.Slice() and unsafe.Pointer().